Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An application with an ' in it's link name totally breaks Ueli #1141

Closed
Roemer opened this issue Jul 13, 2024 · 3 comments
Closed

An application with an ' in it's link name totally breaks Ueli #1141

Roemer opened this issue Jul 13, 2024 · 3 comments

Comments

@Roemer
Copy link

Roemer commented Jul 13, 2024

Describe the bug
I updated from ueli 8 to 9.03 and now everything is broken.
The error I get is:

[13.7.2024, 13:26:17][ERROR] Failed to get search result items for extension with id 'ApplicationSearch.Reason: Error: Command failed: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoProfile -NonInteractive -ExecutionPolicy bypass -File "C:\Users\redacted\AppData\Roaming\ueli\PowershellUtility\53d6dae3-1680-43f3-8e1e-a1576e73bb88.ps1"
In C:\Users\redacted\AppData\Roaming\ueli\PowershellUtility\53d6dae3-1680-43f3-8e1e-a1576e73bb88.ps1:251 Zeichen:248
+ ... FileImageImageGenerator\a43d34b8da0a3b45eccb819c272566aa8725535d.png'
+                                                                         ~
Die Zeichenfolge hat kein Abschlusszeichen: '.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : TerminatorExpectedAtEndOfString

Having a look at the file, I seed that there are applications with an ' in the name which obviously breaks the file. They should be escaped.

In my case, it is the intallation of Sysinternals via scoop which leads to this breaking line:

Get-Associated-Icon -InFilePath 'C:\Users\redacted\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Scoop Apps\SysInternals\CacheSet - Control the Cache Manager's working set size.lnk' -OutFilePath 'C:\Users\redacted\AppData\Roaming\ueli\FileImageImageGenerator\e03d87fd742663eff5ec9845b8209a3cd19e935c.png'

To Reproduce
Steps to reproduce the behavior:

  1. Install Sysinternals via scoop: scoop install extras/sysinternals
  2. Install ueli (via scoop or probably anything else)
  3. Ueli is completely broken

Expected behavior
Ueli works

Environment

  • OS: Windows
  • Version 11
@Roemer Roemer added the bug label Jul 13, 2024
@oliverschwendener
Copy link
Owner

Thanks for all the detailed investigation! The issues reported here might be related.

oliverschwendener added a commit that referenced this issue Jul 14, 2024
…shell scripts

This fixes an issue which breaks the powershell script when a file path contains single quotes (#1141)
@oliverschwendener
Copy link
Owner

Can you try the latest release and check if it works?

@Roemer
Copy link
Author

Roemer commented Jul 15, 2024

Yep, works now with 9.0.4, thanks for the fix.

@Roemer Roemer closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants