Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for rescanning #1309

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

tkohlmeier
Copy link
Collaborator

@tkohlmeier tkohlmeier commented Jan 7, 2025

This adds F5 as a keyboard shortcut for rescanning. I think it is much more convenient than having to enter rescan.

@tkohlmeier
Copy link
Collaborator Author

tkohlmeier commented Jan 19, 2025

Added an entry for the hotkey to the settings:

grafik

Do you think this should be editable or platform-specific?

Also improved some translations.

@oliverschwendener
Copy link
Owner

Here are a few thoughts:

  • I don't think that typing "rescan" is so unintuitive that it needs a keyboard shortcut. If you have to do a rescan very often, consider lowering the rescan interval or mark the "rescan extensions" search result as a favorite, then it shows up higher in the search results. Then, maybe you just have to enter "re" and press enter.
  • "F5" is very Windowsy, please suggest appropriate keyboard shortcuts for the other platforms
  • Be careful with the term "hotkey". I consider the "hotkey" to be the keyboard shortcut that can be pressed outside of the app. Keyboard shortcuts inside of the app I call "keyboard shortcuts". I suggest to rename the "hotkey" in this context to "keyboard shortcut".

@tkohlmeier
Copy link
Collaborator Author

  • I didn't say it's unintuitive, but inconvenient. Ueli 8 had this keyboard shortcut and I used it whenever I installed new software or created new application shortcuts. I don't have automatic rescan enabled since it uses too much resources IMO. Furthermore, why do we have a shortcut for the settings? You can open the settings by searching for "Open Ueli settings` as well, but shortcuts are more convenient.
  • Firefox shortcuts for reload:
    Windows/Linux: F5 or CtrlR
    Mac: F5 or CmdR
    The problem with CtrlR is, that this collides with the Electron reload function. If we disable the menu in the packaged version, the Electron shortcut should not be present anymore.
  • OK, for me those terms were synonymous. If you agree to this feature in general I will adjust it.

@oliverschwendener
Copy link
Owner

Ok also fair enough :)

What do you think about the following?

  • Let's use F5 for all platforms to not collide with electron's refresh keyboard shortcut
  • Let's call it "Keyboard shortcut" in the settings so the term "hotkey" is used solely for the "global hotkey"

@tkohlmeier tkohlmeier changed the title Add hotkey for rescanning Add keyboard shortcut for rescanning Jan 24, 2025
@tkohlmeier
Copy link
Collaborator Author

Sounds good. Just one thing about Electron's refresh function: When we remove the menu in #1327, this shortcut won't be available anymore.

@tkohlmeier tkohlmeier enabled auto-merge (squash) January 25, 2025 14:24
@tkohlmeier tkohlmeier merged commit ea4ff9d into oliverschwendener:main Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants