Update height when receiving new children #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2019
|
@tuomohopia Thank you so much for posting this PR, it's a life-saver. @oliviertassinari Please make a new release with this fix because |
|
Do we know when this fix can be merged? |
|
is it frozen? |
pandaiolo
pushed a commit
to pandaiolo/react-swipeable-views
that referenced
this pull request
Feb 3, 2020
This was an issue we had as well, this PR was the fix for us during the project, I have accepted it to be the official fix for this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic container height issue
This PR is a fix to the container (view) height not updating itself after it receives new children.
Here is the original issue.
Height animation
Personally I don't want this container height update to be animated so I'll remove that in my fork. But I think you want to keep that animation mandatory there so this PR doesn't touch that.