Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::destroy dispatches ::destroy? #45

Closed
iku000888 opened this issue Jul 2, 2019 · 1 comment
Closed

::destroy dispatches ::destroy? #45

iku000888 opened this issue Jul 2, 2019 · 1 comment

Comments

@iku000888
Copy link
Contributor

Hi @oliyh !

This has been really useful, thanks!

I noticed that calling re-graph.core/destroy throws a runtime error, and seemed like commenting this line out made the error stop.

:dispatch [::destroy instance-name]}

I have not looked into the internals much, but it would be awesome if you could highlight some intentions.

More than happy to provide more details as well.

iku000888 added a commit to parkside-securities/re-graph that referenced this issue Jul 2, 2019
@oliyh
Copy link
Owner

oliyh commented Jul 2, 2019

Hi,
The idea is to unsubscribe from any existing subscriptions, and to allow that to happen (as the unsubscribe will require the websocket / instance) before actually destroying the instance.

Thank you for the pull request, it looks good!

@oliyh oliyh closed this as completed in 5dfe6eb Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants