Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate tool calls #213

Merged
merged 5 commits into from
Jul 17, 2024
Merged

integrate tool calls #213

merged 5 commits into from
Jul 17, 2024

Conversation

joshyan1
Copy link
Contributor

No description provided.

BruceMacD
BruceMacD reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, pending a check from @mxyng. I believe the tests wont pass until we release the new ollama version.

mxyng
mxyng approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mxyng mxyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. it'd be nice to define anonymous classes for the functions but there's no way of doing that while also making the linter happy.

@joshyan1 joshyan1 merged commit 359c63d into main Jul 17, 2024
5 checks passed
@joshyan1 joshyan1 deleted the jyan/tools2 branch July 17, 2024 16:40
@allenporter allenporter mentioned this pull request Jul 18, 2024
Merged
20 tasks
@anthonywu anthonywu mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD left review comments

@mxyng mxyng mxyng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshyan1 @mxyng @BruceMacD