add pydantic for validation and serialization #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
force-pushed
the
mxyng/pydantic
branch
from
a4f0995 to
2b95c17
Compare
mxyng
force-pushed
the
mxyng/pydantic
branch
from
2b95c17 to
5f4496e
Compare
ParthSareen
reviewed
Nov 6, 2024
ParthSareen
reviewed
Nov 6, 2024
|
See #311 for pydantic type class fixes and serialization |
ParthSareen
approved these changes
Nov 6, 2024
ParthSareen
requested changes
Nov 7, 2024
ollama/_client.py
Outdated
| 'Content-Type': 'application/json', | ||
| 'Accept': 'application/json', | ||
| 'User-Agent': f'ollama-python/{__version__} ({platform.machine()} {platform.system().lower()}) Python/{platform.python_version()}', | ||
| }.update(headers or {}), |
There was a problem hiding this comment.
.update() is going to return a None which means no headers will get passed in
* Added SubscriptableBaseModel to the Model classes and added Image codec test --------- Co-authored-by: Parth Sareen <parth@Parths-MacBook-Pro.local>
* Fixing empty header + ensuring security
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while the interface should be backwards compatible, i.e. most tests and examples do not need any changes, this change wants a minor version bump
examples should be updated in a following change to use pydantic models where appropriate