Type handler #7
Open
Type handler #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taherkl
requested review from
akash-furax and
akashthawaitcc
and removed request for
akashthawaitcc
taherkl
requested changes
Dec 9, 2024
...o-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/TypeHandler.java
Outdated
Show resolved
Hide resolved
| return ByteBuffer.wrap(byteArray); | ||
| } | ||
|
|
||
| public static Date handleCassandraDateType(String colName, JSONObject valuesJson) { |
There was a problem hiding this comment.
What is the need of passing column name? We can just pass the value and get the new casted value in return? This will be for all the functions.
There was a problem hiding this comment.
as we are doing multiple parsing so it should be under the Handler Class
|
@pawankashyapollion Add a description with the list of datatypes covered in this PR alongwith the list of datatypes which are yet to covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type handler is used for Casting source type to Cassandra supported type
Current Supported data type are:
Boolean
Float
Double
Date
String
Text
Timestamp
Integer
List
Set
TODO
We are going to create a common method which is common integration point of this class and then we will mark all of this method to private. we have kept this method public for a while to wire up UT