updated initialization process #4
Conversation
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // // Copyright 2020 Google LLC |
| @@ -828,7 +833,7 @@ func parseRow(r *spanner.Row, colDDL map[string]string) (map[string]interface{}, | |||
| } | |||
| singleRow[k] = m | |||
| } | |||
| case "INT64": | |||
| case "N": | |||
There was a problem hiding this comment.
Have u tested the scenarios for INT64, FLOAT64, NUMERIC as all will be N on dynamo
| case "S": | ||
| return "STRING(MAX)" | ||
| case "N": | ||
| return "FLOAT64" |
There was a problem hiding this comment.
Are we storing all N as FLOAT64?
There was a problem hiding this comment.
What about INT64 &, NUMERIC?
There was a problem hiding this comment.
Add apache license header
| } | ||
|
|
||
| // Extract attributes from the table | ||
| attributes := make(map[string]string) |
There was a problem hiding this comment.
Do we need to scan entire table? Should this be simply output.Table.AttributeDefinitions
There was a problem hiding this comment.
AttributeDefinitions does not specify the roles of these attributes (i.e., whether they are HASH or RANGE keys), it only contains the attribute names and their data types.
https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_TableDescription.html#DDB-Type-TableDescription-KeySchema
Fixes #<issue_number_goes_here>