Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with run_setup and dronecan #228

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmcadam
Copy link
Collaborator

@tmcadam tmcadam commented Nov 11, 2024

This is very rough, but demonstrates a fix for the issue with dronecan failing in run_setup.py

  • Creates a python virtual environment in the mLRS/common/dronecan folder.
  • Installs the dependencies
  • Runs the dronecan steps with the python executable from virtual env

ONLY TESTED ON LINUX!

@tmcadam tmcadam changed the title Fix issue with run_setup and drone can Fix issue with run_setup and dronecan Nov 11, 2024
@jlpoltrack
Copy link
Collaborator

Brilliant - confirming it worked for me on MacOS.

@olliw42
Copy link
Owner

olliw42 commented Nov 11, 2024

oh my gosh ... that's really above my head ... and since I guess I have to maintain that scrupt "scares" me ...
we really need that?
I mean, it's super elegangt and professional, but ... over the top of my head ...

@tmcadam
Copy link
Collaborator Author

tmcadam commented Nov 11, 2024

Hmmm, this is actually an unusual way of doing it, but it keeps it all in a python script, and keeps it cross-platform. I guess other option is to replace to run_setup.py with run_setup.bat(windows) and run_setup.sh(linux mac). These shell scripts can install the dronecan dependencies and run the other python scripts, that would be the more common way of doing it.

Last option is to just document the installation steps for the 4 python dependencies before running run_setup.py and let devs do it themselves. I think you still need to setup python virtual environment for this, the more recent versions of python seem to increasingly severe warnings on system-wide dependency installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants