-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully implement ERB-like syntax (eRuby) #9
Comments
I like all of this 👍 |
Is there anything missing? I've also found out using
Should the syntax require a whitespace after/before the start/end tag? E.g. |
I've never used |
I might still implement the minus option since it shouldn't be a big deal and it's deactivated by default (as long as not specified in Should parrot.render(input, {
trim_mode: undefined, // default
...
}); parrot.render(input, {
tags: {
trim_mode: undefined, // default
...
}
}); The first one has less nesting and might be better if the tags aren't changed often (or custom tag support is dropped / unofficial in the future). The second one is obviously better categorized. |
After this https://review.openstack.org/#/c/85168/ code review merged, the neutron services are failed to start becuase of -%> in neutron.conf.rb template, -%> as end tag would omit a following newline. please refer to https://github.com/ruby/ruby/blob/trunk/lib/erb.rb ollym/parrot#9 (comment) Change-Id: Ia35a51fc67c2305be6bdc975c924d421ba4f1313
See ERB in the Ruby documentation:
This also features some escaping for ERB tags.
The
trim_mode
parameter is interesting, too:The text was updated successfully, but these errors were encountered: