Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing import and export, fixing issue with Webpack #238

Closed
wants to merge 3 commits into from

Conversation

0cv
Copy link

@0cv 0cv commented Mar 22, 2016

This is a fix for #227 and might help partially that: #237

@0cv
Copy link
Author

0cv commented Mar 24, 2016

I'm using it in our development since my pull request, and it works as long as you're mindful, but it's clearly a bit fragile and there are cases which not work. Among others:

  • export default angular.module(...).config(function("$willNotGetAnnotated"){}) will fail being annotated. But moving the function outside solves the issue.
  • there is no "automatic" annotation, so that when using a function/class in a standalone module (file), it will obviously be ignored by the current logic. A manual @ngInject is necessary.
  • "ngInject", depending on the situation, does not work. /@ngInject/ will, as far as I have seen so far, always work.

@vperron
Copy link

vperron commented Apr 8, 2016

Albeit being fragile, at least we'll be able to get minimal import/export support in ng-annotate. I guess improving it to make it 100% functional will follow. Every little effort helps. Right now I don't have time to do this, but with that merged at least I won't change my toolchain :)

@olov
Copy link
Owner

olov commented Jun 8, 2016

#245

@olov
Copy link
Owner

olov commented Oct 1, 2016

#245

@olov olov closed this Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants