Publish as Curl.Parser.Net and Curl.Converter.Net as NuGet packages #99
Conversation
|
@olsh Please have a look. Thanks. |
| @@ -0,0 +1,52 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
I don't think that the package is not useful per se. I'd suggest merging the code into Curl.Converter.Net project.
Let me know what do you think.
There was a problem hiding this comment.
Don't really get what you mean. Do you mean merging Curl.Parser.Net to Curl.Converter.Net?
There was a problem hiding this comment.
Do you mean merging Curl.Parser.Net to Curl.Converter.Net?
Yes
There was a problem hiding this comment.
@olsh I think it can be separated because the output from the Curl.Parser.Net can be used to generate for example JS code based on the project need. In this case, they don't have to include the Curl.Converter.Net project. What do you think?
There was a problem hiding this comment.
Good point, agree. Then probably we should give more precise names for the libraries?
How about:
Curl.CommandLine.Parser
Curl.HttpClient.Converter
?
In this case we can implement another converters in the future like:
Curl.Flurl.Converter
Curl.RestSharp.Converter
src/Curl.Parser.Net/Models/Parsing/KeyTypeParameterEvaluator.cs
Outdated
Show resolved
Hide resolved
|
Hi @jiahao1553, Thank you for a great job! 🔝 |
|
@olsh I updated the code based on your comments. Let me know if there is anything else you need me to update 😊 |
|
Hi @jiahao1553 |
|
@olsh please take a look at my reply. Thanks |
|
@jiahao1553 which one? |
|
@olsh this is the reply I meant. Hope it answer your question. |
| @@ -0,0 +1,52 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Good point, agree. Then probably we should give more precise names for the libraries?
How about:
Curl.CommandLine.Parser
Curl.HttpClient.Converter
?
In this case we can implement another converters in the future like:
Curl.Flurl.Converter
Curl.RestSharp.Converter
Ouch, my bad, I forgot to hit the request changes button. |
|
@olsh changes are done. Please take a look. Thanks 😊 |
There was a problem hiding this comment.
@jiahao1553 could you please take a look at the suggestions?
src/Curl.CommandLine.Parser/Models/Parsing/HeaderParameterEvaluator.cs
Outdated
Show resolved
Hide resolved
src/Curl.CommandLine.Parser/Models/Parsing/ParameterEvaluator.cs
Outdated
Show resolved
Hide resolved
|
Replied and updated the code. Please take a look @olsh |
|
@jiahao1553 let's drop .netstandard and try to keep the code as it is for now. |
|
@olsh I have completed the changes. Please take a look. Thanks. |
|
Thank you for the contribution |
|
You're welcome @olsh :) |
|
@jiahao1553 |
Sorry for the delay in making the code changes you mentioned in #63.
Please review the request. Thank you.