Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support returning sync token values after committing transactions (batching). #29

Closed
AhmedZaki99 opened this issue Aug 31, 2023 · 1 comment · Fixed by #30
Closed

Support returning sync token values after committing transactions (batching). #29

AhmedZaki99 opened this issue Aug 31, 2023 · 1 comment · Fixed by #30

Comments

@AhmedZaki99
Copy link
Contributor

As stated in the official documentation under Add two new tasks section:

In the results, we see the following data:

  • A new sync_token which we can use later on to do more incremental syncs.

These sync tokens returned by batching requests can be very helpful in keeping the sync state.

My suggestion here is to make the ITransaction.CommitAsync() return Task<string> that when completed returns the sync_token value, instead of just empty Task.

That change is expected not to have side effects since the Task<string> behaves exactly like a plain Task but with a result.

Thanks in advance for your time and for the great package 🙂

@AhmedZaki99
Copy link
Contributor Author

I've opened a pull request for the suggested changes.

@olsh olsh closed this as completed in #30 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant