Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning sync token values after committing transactions. #30

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

AhmedZaki99
Copy link
Contributor

@AhmedZaki99 AhmedZaki99 commented Aug 31, 2023

Fixes #29

Changes include:

  • Update the SyncResponse model with a new property SyncToken that maps to sync_token Json property on the transaction response.
  • Update the IAdvancedTodoistClient.ExecuteCommandsAsync and its implementation in TodoistClient to return Task<string> containing the sync_token included in the response instead of plain Task.
  • Update the ITransaction.CommitAsync() and its implementation in Transaction to return Task<string> following the change made in IAdvancedTodoistClient.ExecuteCommandsAsync.
  • Add assertion in TransactionTests.CreateProjectAndCreateNote_Success() test method to check the sync_token value returned by the ITransaction.CommitAsync() method.

@olsh olsh merged commit 7460f38 into olsh:master Aug 31, 2023
@olsh
Copy link
Owner

olsh commented Aug 31, 2023

Thank you for your contribution! 👍🏻

@AhmedZaki99 AhmedZaki99 deleted the patch-1 branch August 31, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support returning sync token values after committing transactions (batching).
2 participants