Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority mapping is incorrect #63

Closed
zotanmew opened this issue Jan 29, 2025 · 3 comments
Closed

Priority mapping is incorrect #63

zotanmew opened this issue Jan 29, 2025 · 3 comments

Comments

@zotanmew
Copy link

The sync docs API read:

priority: Integer
The priority of the task (a number between 1 and 4, 4 for very urgent and 1 for natural).
Note: Keep in mind that very urgent is the priority 1 on clients. So, p1 will return 4 in the API.

This is not currently reflected in the Priority model. Either the enum member names, or both the names and the values should be adjusted to reflect the actual priority.

@zotanmew
Copy link
Author

I'm happy to PR this if you could tell me which variant you'd prefer.

@olsh
Copy link
Owner

olsh commented Jan 29, 2025

Either the enum member names, or both the names and the values should be adjusted to reflect the actual priority.

This is a breaking change anyway, so let's update both.

@zotanmew
Copy link
Author

Alright, I'll implement it after touching up the previous PR.

zotanmew added a commit to zotanmew/todoist-net that referenced this issue Jan 29, 2025
olsh added a commit that referenced this issue Feb 3, 2025
@olsh olsh closed this as completed in 184e5f7 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants