Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction failures for predefined temp_id of new entities #44

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Fix transaction failures for predefined temp_id of new entities #44

merged 4 commits into from
Dec 27, 2023

Conversation

AhmedZaki99
Copy link
Contributor

Fixes #43

  • As suggested in the issue, extra tests were added to ensure that predefined TempId values for the create commands are working properly.
  • The suggested fix for it was to check for existing TempId values first in CommandServiceBase.CreateAddCommand before creating new ones.

@olsh
Copy link
Owner

olsh commented Dec 27, 2023

Thank you for the contribution! 👍🏻

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AhmedZaki99 AhmedZaki99 requested a review from olsh December 27, 2023 09:00
@olsh olsh merged commit 39411f7 into olsh:master Dec 27, 2023
@AhmedZaki99 AhmedZaki99 deleted the patch-6 branch December 27, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olsh olsh Awaiting requested review from olsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temp ID assigned to new entities differ from Temp ID in thier add commands
2 participants
@AhmedZaki99 @olsh