Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem saving on Configuration Editor for certain tables #134

Open
lostcarpark opened this issue Aug 26, 2021 · 2 comments · May be fixed by #138
Open

Problem saving on Configuration Editor for certain tables #134

lostcarpark opened this issue Aug 26, 2021 · 2 comments · May be fixed by #138

Comments

@lostcarpark
Copy link

lostcarpark commented Aug 26, 2021

If I try to save a new row on the Rooms table, it fails because the DB table does not allow an empty string to be inserted into a Time field. I guess it would work if I specified times for all 6 open/close time fields, but there is no validation checking on the time fields. A possible fix would be to change SubmitEditConfigTable.php to save NULL rather than '' for empty cells.

If I try to save a new row to the RoomHasSet table, or select a different room or room set for an existing row, it fails to insert or update. It would appear that it attempts to insert/update the the room name/roomset name instead of the ID, and the insert fails because a numeric value is expected. The problem would appear to be that the JavaScript is putting the name rather than the ID into the grid.

This problem occurs on the Discon3 branch.

@LVerhulst4321
Copy link
Collaborator

Whoops. My commit should not be part of this issue. I don't know how to unlink it from this issue.

@olszowka
Copy link
Owner

@LVerhulst4321 The #134 in the commit message caused the commit to be linked to this issue by github.

@lostcarpark lostcarpark linked a pull request Aug 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants