Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox Lack of Encoding Causes Connection Failures #173

Closed
empty opened this issue Jan 22, 2014 · 4 comments
Closed

Dropbox Lack of Encoding Causes Connection Failures #173

empty opened this issue Jan 22, 2014 · 4 comments

Comments

@empty
Copy link

empty commented Jan 22, 2014

With the change to #139 now Dropbox connections fail. Dropbox doesn't seem to have the encoding set in the Requests library which causes the decode method to fail with: "TypeError: decode() argument 1 must be string, not None" on line 174 of social.backends.oauth in unauthorized_token. I'd suggest just using the old behavior in the case of no encoding or possibly use response.apparent_encoding but I'm not really sure what all that does.

@omab
Copy link
Owner

omab commented Jan 23, 2014

@empty, could you try master with the change pushed above?

@empty
Copy link
Author

empty commented Jan 23, 2014

@omab Yep I'll give it a shot tomorrow. Thanks.

@empty
Copy link
Author

empty commented Jan 24, 2014

@omab Works perfectly. Thank you.

@omab
Copy link
Owner

omab commented Jan 25, 2014

Cool, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants