Broken partial auth with Django and 0.1.24 #291
Comments
|
The code which I think is broken: https://github.com/omab/python-social-auth/blob/master/social/strategies/base.py#L137 |
nijel
added a commit
to WeblateOrg/weblate
that referenced
this issue
May 28, 2014
See omab/python-social-auth#291 Signed-off-by: Michal Čihař <michal@cihar.com>
omab
added a commit
that referenced
this issue
Jun 7, 2014
|
@nijel, I've introduced a fix for the issue, could you give it a try? |
|
Thanks it seems to work. |
nijel
added a commit
to WeblateOrg/weblate
that referenced
this issue
Jun 9, 2014
0.1.24 - 0.1.26 suffer by omab/python-social-auth#291 Consequent releases will change API for pipeline and the new API is not supported by Weblate (and I'm not sure if it will be possible to support both of them). Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since commit b1fa8bc the partial authentication is broken in Django (at least for my use case). I've tracked down the problem to the fact that
responseis no longer stored in the session data. This is due to fact thatpartial_to_sessionremoves it since b1fa8bc as it does filtering on all elements, while before it did that only on the ones being added from kwargs (responsewas added unfiltered before and now it's filtered).However I think the broken piece of code is the one documented as "Clean any MergeDict data type from the values", which obviously does not convert the MergeDict to dict and it's then filtered. I'm not sure how to fix this properly as importing Django specific class into generic PSA code does not sound correct.
The text was updated successfully, but these errors were encountered: