Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves some revoke_token related errors (BaseOAuth1 and FacebookOAuth2) #158

Merged
merged 2 commits into from
Jan 14, 2014

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jan 14, 2014

When revoking tokens for twitter and facebook I came across some errors than this PR solves:

  • Twitter backend had no "revoke_token" method
  • Facebook backend had a typo o n "process_revoke_token_response"

omab added a commit that referenced this pull request Jan 14, 2014
Solves some revoke_token related errors (BaseOAuth1 and FacebookOAuth2)
@omab omab merged commit 08ef598 into omab:master Jan 14, 2014
@omab
Copy link
Owner

omab commented Jan 14, 2014

Thanks for the change. Moving it to BaseAuth doesn't make sense since not all the approaches support a revoke option in their standard definition.

@jgsogo jgsogo deleted the revoke_fix branch January 16, 2014 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants