Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kakao backend #261

Merged
merged 1 commit into from
May 1, 2014
Merged

Add Kakao backend #261

merged 1 commit into from
May 1, 2014

Conversation

momamene
Copy link
Contributor

@omab
Copy link
Owner

omab commented Apr 30, 2014

The code looks good except for the failing test, looks like the docs doesn't specify this return format https://github.com/momamene/python-social-auth/blob/9caf545ccb23955d9a2e26c20ac05923aae7a1ba/social/tests/backends/test_kakao.py#L13-L25, instead it should be:

    user_data_body = json.dumps({
        'id': '101010101',
        'properties': {
            'nickname': 'foobar',
            'thumbnail_image': 'http://mud-kage.kakao.co.kr/14/dn/btqbh1AKmRf/ujlHpQhxtMSbhKrBisrxe1/o.jpg',
            'profile_image': 'http://mud-kage.kakao.co.kr/14/dn/btqbjCnl06Q/wbMJSVAUZB7lzSImgGdsoK/o.jpg'
        }
    })

Right? That's what the backend is expecting too. I'm not 100% sure since I can't read the site :)

@momamene
Copy link
Contributor Author

momamene commented May 1, 2014

Thank you for your advice!
I fixed user_data_body and get_user_details of kakao.py.
Now it passes tests.

omab added a commit that referenced this pull request May 1, 2014
@omab omab merged commit 881d4f0 into omab:master May 1, 2014
@omab
Copy link
Owner

omab commented May 1, 2014

Great, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants