Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GoogleOAuth2 Spec #407

Merged
merged 1 commit into from
Oct 3, 2014
Merged

Use new GoogleOAuth2 Spec #407

merged 1 commit into from
Oct 3, 2014

Conversation

jaitaiwan
Copy link
Contributor

As per #406 we've added in the openid to the GoogleOAuth2 class as per the documentation located here.

It's important to note here that openid must be first in the list of scopes as per the documentation. @avances123 this is the pull request I referenced in IRC

As per omab#406 we've added in the openid to the GoogleOAuth2 class as per the documentation located [here](https://developers.google.com/accounts/docs/OAuth2Login).

It's important to note here that openid must be first in the list of scopes as per the documentation. @avances123 this is the pull request I referenced in IRC
omab added a commit that referenced this pull request Oct 3, 2014
Use new GoogleOAuth2 Spec
@omab omab merged commit 428f607 into omab:master Oct 3, 2014
@omab
Copy link
Owner

omab commented Oct 3, 2014

Thanks!

@ashchristopher
Copy link

Given that GoogleOAuth2 and GoogleOpenIdConnect are two different backends that can be used independently, shouldn't openid only be necessarily applied to the GoogleOpenIdConnect backend? To use GoogleOAuth2, using the openid scope is definitely not required.

cc: @dlanger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants