Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for django 1.9 #550

Merged
merged 1 commit into from
Apr 2, 2015
Merged

update for django 1.9 #550

merged 1 commit into from
Apr 2, 2015

Conversation

DanielJDufour
Copy link
Contributor

Added some initialization code to a new ready method in the PythonSocialAuthConfig because of changes in Django. See https://docs.djangoproject.com/en/1.7/ref/applications/ and https://docs.djangoproject.com/en/1.7/releases/1.7/.

I'm a big fan and feel free to disregard if you already got some code in the works.

Thank you!

@omab
Copy link
Owner

omab commented Mar 14, 2015

The code looks good and I like it, but I have some concerns about backward compatibility, maybe we can keep the code in the __init__.py with a version check to keep it compatible?

@omab omab merged commit b51629f into omab:master Apr 2, 2015
@omab
Copy link
Owner

omab commented Apr 2, 2015

I've implemented the mentioned change and merged the work. Thanks!

This was referenced Apr 4, 2015
@DanielJDufour
Copy link
Contributor Author

Thanks dude. If you're ever in DC, first round is on me!

@sohamnavadiya
Copy link

sohamnavadiya commented Dec 31, 2016

I am trying to upgrade django 1.7 to 1.9.11 and after upgrade it, I am getting below error.

from social_django.models import AbstractUserSocialAuth, UserSocialAuth, Nonce, Association, Code, DjangoStorage
ImportError: No module named social_django.models

@omab
Copy link
Owner

omab commented Dec 31, 2016

@sohamnavadiya did you install the package social-auth-django?

@sohamnavadiya
Copy link

sohamnavadiya commented Dec 31, 2016

@omab I have installed social-auth-app-django (0.1.0)
I fixed above error. But not I am getting below error.

 "INSTALLED_APPS." % (module, name)
RuntimeError: Model class social_django.models.UserSocialAuth doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.

@omab
Copy link
Owner

omab commented Dec 31, 2016

@sohamnavadiya
Copy link

sohamnavadiya commented Dec 31, 2016

@omab Now I am getting below exception stack.

File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/Documents/django_upgrade_venv/cubii_upgrade_1_9/local/lib/python2.7/site-packages/social_django/models.py", line 30, in <module>
    class AbstractUserSocialAuth(models.Model, DjangoUserMixin):
  File "/home/Documents/django_upgrade_venv/cubii_upgrade_1_9/local/lib/python2.7/site-packages/django/db/models/base.py", line 105, in __new__
    app_config = apps.get_containing_app_config(module)
  File "/home/Documents/django_upgrade_venv/cubii_upgrade_1_9/local/lib/python2.7/site-packages/django/apps/registry.py", line 237, in get_containing_app_config
    self.check_apps_ready()
  File "/home/Documents/django_upgrade_venv/cubii_upgrade_1_9/local/lib/python2.7/site-packages/django/apps/registry.py", line 124, in check_apps_ready
    raise AppRegistryNotReady("Apps aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.

@sohamnavadiya
Copy link

sohamnavadiya commented Dec 31, 2016

@omab I solved above issue. By the way thanks for quick reply. I really appreciate your work.

@omab
Copy link
Owner

omab commented Dec 31, 2016

@sohamnavadiya no problem, do you mind posting the solution, I know that transitions aren't always smooths and could be useful to somebody else experiencing the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants