Fix Django 1.10 Deprecation Warning "SubfieldBase has been deprecated."

[contracode]

Removed metaclass syntax to break the dependency on django.db.models.SubfieldBase, which has been deprecated in Django 1.9 and will be removed with Django 1.10.

Fixes #804 and #754. Extends fix provided by #806.

[gustavi]

Thank you for the PR, someone can review and merge it ?

[gustavi]

Some news ?

[gustavi]

?

[yprez]

+1

[yprez]

Also fixes #812 #811 #801

[liminspace]

+1

[blueyed]

Please stop +1'ing without providing some input/findings/patch.

FWIW, you can use something like the following to filter out warnings unrelated to your project:

import project
PROJECT_PATH = os.path.dirname(project.__file__)

def filter_deprecation_warnings(record):
    warnings_to_suppress = [
        'RemovedInDjango110Warning'
    ]
    msg = record.getMessage()
    return not any([warn in msg
                    for warn in warnings_to_suppress
                    if not msg.startswith(PROJECT_PATH)])
logging.getLogger('py.warnings').addFilter(filter_deprecation_warnings)

[yprez]

@blueyed this is the patch... just showing that there is interest (github lacks voting).

[blueyed]

@yprez
You've added some info at least, so that was OKish.

It was meant more in general.

And regarding your comment (which were actually 2, so two emails for maintainers), it would be better to add it to the duplicate issues and reference this one from there, clearing stating that it's a dupe / fixed by this PR - so it can be easily triaged.
Otherwise all the noise will only make it harder for maintainers.
That's also why we should stop here discussing this.

[contracode]

Is there anything I can clarify or add to get this PR merged?

[duducosmos]

+1

[PetrVasilev]

Where i have to add "def filter_deprecation_warnings(record):" in my project???

[yamashitadesu]

Hi, I also have the Bug with Django 1.9.2.
I found this page, and I reinstalled python-social-auth by
$ git clone https://github.com/omab/python-social-auth
and
$ python setup.py install

But I still have the Bug. Should I use Django 1.10? Or Can I solve this Bug on Django 1.9?

Thank you.

[PetrVasilev]

Hi, I also have this bug, and I tried fix it. You can do exception in
your project, and it will works.

2016-02-20 9:57 GMT+09:00 yamashitadesu notifications@github.com:

Hi, I also have the Bug with Django 1.9.2.
I found this page
http://stackoverflow.com/questions/34321332/subfieldbase-has-been-deprecated-use-field-from-db-value-instead,
and I reinstalled python-social-auth by
$ git clone https://github.com/omab/python-social-auth
and
$ python setup.py install

But I still have the Bug. Should I use Django 1.10? Or Can I solve this
Bug on Django 1.9?

Thank you.

—
Reply to this email directly or view it on GitHub
#813 (comment)
.

// Васильев Петр Алексеевич

[gustavi]

I have no idea why nobody wants to merge it. Really.

[PetrVasilev]

Me too, it is really bad problem for me

2016-02-20 19:38 GMT+09:00 Laville Augustin notifications@github.com:

I have no idea why nobody wants to merge it. Really.

—
Reply to this email directly or view it on GitHub
#813 (comment)
.

// Васильев Петр Алексеевич

[contracode]

Could you review and merge this, please, @omab? If you do not have the time to do this, please consider granting me write access to this repo. I can ensure you that I will assist you in bug triage, pull request review/merge, and the other maintenance tasks related to providing quality code to the world.

[evcb]

Can it be also updated on pip repository?

[AlbertPuchala]

When I change this line manually and try to use Google auth, I get Error:

AttributeError at /accounts/social/complete/google-oauth2/
'str' object has no attribute 'update'
Request Method: GET
Request URL: http://myapp.com:8000/accounts/social/complete/google-oauth2/?state=2M0kJYG5Y6gY2168PvXZYoSASqvkaGhk&code=4/oSlipMXmeksLQO8ekcGnWVtm9ZPFv1oBpJptr4Cm0wk&authuser=0&session_state=150dc7ee96507db45d657099378028204c576a4a..dfee&prompt=none
Django Version: 1.9.2
Exception Type: AttributeError
Exception Value:
'str' object has no attribute 'update'
Exception Location: /home/albert/HomeFinder/env/lib/python3.4/site-packages/social/storage/base.py in set_extra_data, line 85
Python Executable: /home/albert/HomeFinder/env/bin/python
Python Version: 3.4.3

Without this change everything works fine.
What am I doing wrong?

[evcb]

@AlbertPuchala What was the modification you made? I believe I have to add and not isinstance(self.extra_data, str).

[AlbertPuchala]

@hellvix Thanks, now it works :).
But shouldn't that (which you've pasted) change be appended to this branch?

[evcb]

@AlbertPuchala It should, but I believe @omab is really busy. He hasn't been updating the stuff we have around.

[vaibhavmule]

Any progress on this?

[omab]

Sorry about the delay, I'm very busy but slowly catching up with all the PRs proposed.

Thanks!

[evcb]

Should have been fixed. Update your version and let us know here the
outcome.
On 20 Apr 2016 10:58, "Julian Bez" notifications@github.com wrote:

@hellvix https://github.com/hellvix was the fix added? I have the same
problem as @AlbertPuchala https://github.com/AlbertPuchala.. which line
do I need to change?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#813 (comment)

[cleder]

This warning in Django 1.9 may be a red herring. I did have it and migrated to 1.10 without any problems. If you are on 1.9 and the warning holds you back, just give it a try to migrate to 1.10 (and run your tests ;-) )

[ashishpahwa7]

I have migrated to 1.10 and still facing the same issue :

class JSONField(six.with_metaclass(models.SubfieldBase,models.TextField)): AttributeError: 'module' object has no attribute 'SubfieldBase'