Storing token_type in extra_data field when using OAuth 2.0 #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is useful for authentication servers that may provide multiple types of tokens.
|
@omab please review. |
|
@omab any feedback? |
|
@clintonb thanks for this PR, I've merged it but ran PEP8 on it first. |
|
Thanks @omab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value is useful for authentication servers (AS) that may provide multiple types of tokens. Most servers use the
Bearertoken type; however, we at @edx are transitioning to usingJWT. The ability to make the switch without having to change our backend would be ideal. Storing the token type means we can avoid hardcoding the value and let the access token response determine which scheme is used for future requests made using the issued token.