Try poetry #10
Open
Try poetry #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazza-codes
force-pushed
the
try-poetry
branch
2 times, most recently
from
3cdce5d
to
b8a7426
Compare
use poetry tasks for: - make rules - travis-CI builds
- update pyproject.toml - update travis-CI
|
Sorry for the looooooong delay in reacting to this. Are you still interested in this pull request? If yes, could you explain the benefit this has over the current approach? |
|
Avoid poetry, or flit, use setuptools-scm... |
|
I am no longer doing much development with Python so I am not up to date with the latest best practices. I need some justification why poetry (or setuptools-scm) is the way to go, ideally some list of advantages and disadvantages with sources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a by-product of attempting to create a dev-env for this project, using poetry. It's thrown up as a PR in case it is useful to others too.