Merge PR #9 from dev

fix: removed litteral \n in echo and refactor some guide
ombhd · May 11, 2022 · a70645b · a70645b
2 parents 2a86cbb + 0fa961e
commit a70645b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/my_tools_installer.bash b/my_tools_installer.bash
@@ -92,7 +92,7 @@ cleanup() {
  shell_f="${HOME}/.${SHELL_LANG}rc"
  brew &>/dev/null
  if [[ "$?" == "127" ]]; then
- echo -e "\n\033[32m ⛔️ You need to update the PATH variable with this command: [ source $shell_f ]\033[0m\n"
+ echo -e "\n\033[32m ⛔️ Please, run this command: [ source $shell_f ]\033[0m\n"
  exit 1
  fi
  exit 0

diff --git a/scripts/nvm_installer.bash b/scripts/nvm_installer.bash
@@ -80,7 +80,8 @@ mkdir "$HOME"/goinfre/.nvm &>/dev/null
 ln -s "$HOME"/goinfre/.nvm "$HOME"/.nvm &>/dev/null
 
 # add the nvm config the shell config file
-echo "\n# nvm configuration\n" >>"$shell_f"
+echo >> "$shell_f"
+echo "# nvm configuration" >>"$shell_f"
 echo 'export NVM_DIR=$HOME/.nvm' >> "$shell_f"
 echo '[ -s "$HOME/goinfre/.brew/opt/nvm/nvm.sh" ] && \. "$HOME/goinfre/.brew/opt/nvm/nvm.sh" # This loads nvm' >> "$shell_f"
 echo '[ -s "$HOME/goinfre/.brew/opt/nvm/etc/bash_completion.d/nvm" ] && \. "$HOME/goinfre/.brew/opt/nvm/etc/bash_completion.d/nvm" # This loads nvm bash_completion' >> "$shell_f"
@@ -100,6 +101,6 @@ fi
 
 
 # tell the user to source the shell config file
-echo -e "\n\033[32m ⛔️ You need to update the PATH variable with this command: [ source $shell_f ]\033[0m\n"
+echo -e "\n\033[32m ⛔️ Please, run this command: [ source $shell_f ]\033[0m\n"
 echo -e "\n\033[33m You can install any node version you want with [ nvm install version_number ] \033[0m"
 echo -e "\n\033[33m ex: nvm install 17 \033[0m"