Molecule v2

[sbesson]

This PR makes the necessary changes to test this role with Ansible 2.4 and Molecule 2.

• 2d2c391 creates the Molecule 2 initial setup using molecule init scenario -r $(basename $PWD) -s default -d docker
• f755bd2 fixes the yamllint warnings and errors reported by molecule test and upgrades tests to be compliant with Molecule 2/testinfra 1.14
• 9c97dcc adds tests for installed packages

With ome/ome-ansible-molecule#10, this PR should be tested by Travis against Ansible 2.4 in the daily https://travis-ci.org/snoopycrimecop/ansible-roles build.

Proposed tag: 1.0.1

See also #4

[sbesson]

See https://travis-ci.org/snoopycrimecop/ansible-roles/builds/428194277 and more specifically https://travis-ci.org/snoopycrimecop/ansible-roles/jobs/428194280 showing this works together with ome/ome-ansible-molecule#10.

The number of failures gives us a feeling of how much we need to fix to be forward compatible with Ansible 2.4/Molecule 2. Here's a proposed roadmap for the next steps:

• merge this PR & cut a a patch release of the role
• open issues against all the roles that need to be tested by molecule v2
• fix and release all these roles
• cut a pre-release of ome-ansible-molecule-dependencies e.g. a1
• try to consume Ansible 2.4 compatible roles in https://github.com/openmicroscopy/prod-playbooks and/or https://github.com/IDR/deployment
• make the final release of ome-ansible-molecule-dependencies upgrading to Ansible 2.4
• cleanup the old molecule_v1 files in the roles repo

Thoughts?

[manics]

Is it worth skipping straight to Ansible 2.5 (I think I've already tried this version with IDR/deployment but would need to double-check) or 2.6?

[sbesson]

A few immmediate thoughts about #5 (comment) although this probably will need to be sorted over a voice discussion:

• although this PR could be impacted, Bump to ansible 2.4 ome-ansible-molecule#10 is probably where the proposed version bump would need to happen
• looking at https://pypi.org/project/ansible/#history, it looks like Ansible 2.4 is still somewhat maintained, 2.5 and 2.6 are the current active ones and 2.7 is upcoming. Ansible 2.4 was kept here to match the decision made when opening Bump to ansible 2.4 ome-ansible-molecule#10 . I have no strong opinion in terms of the minor version of Ansible to target but I would be interested to know the major features that our deployments could benefit from with 2.5 or 2.6 and whether any of these versions would create extra upgrade cost.
• once we have settled on the version, as mentioned in Molecule v2 #5 (comment), I would be in favor of upgrading of all our roles asap. Out of the 30 roles still failing in https://travis-ci.org/snoopycrimecop/ansible-roles, this probably means distributing 5-10 amonst each of us and making the necessary changes to get Molecule 2 passing.

[manics]

• 2.4 is supported for security fixes only. https://docs.ansible.com/ansible/2.6/reference_appendices/release_and_maintenance.html
• 2.5 roadmap https://docs.ansible.com/ansible/latest/roadmap/ROADMAP_2_5.html
• 2.6 roadmap https://docs.ansible.com/ansible/latest/roadmap/ROADMAP_2_6.html

Nothing stands out as immediately useful, though the additional support for cloud provisoining might be useful in future. If we're going through the process of testing all roles (and based on your PR description changes to roles will be required) I think we should go for 2.6 if there are no obvious problems, 2.5 if not.

[manics]

One optional comment

[manics]

I know it's auto-generated, but I this it'd be better to remove INSTALL.rst since we have our own set of dependencies.

[sbesson]

See ba6baa7

[manics]

Thanks 👍

[sbesson]

Now released as 1.0.1 and deployed to https://galaxy.ansible.com/openmicroscopy/basedeps