Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name #13

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Change package name #13

merged 1 commit into from
Nov 19, 2024

Conversation

khaledk2
Copy link
Contributor

This PR changed the installation package to fix the issue described on IDR/deployment#438

@sbesson sbesson closed this Oct 21, 2024
@sbesson sbesson reopened this Oct 21, 2024
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is very minimal. Do you have a link that explains why this package was superseded by iptables-nft-services?

The Molecule tests in this role did not fail when enabling the service but I can reproduce the error in the context of the IDR playbooks Molecule tests. Does that point at something else that the IDR playbooks causing an issue with this component?

From a quick search I came across https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/configuring_firewalls_and_packet_filters/getting-started-with-nftables_firewall-packet-filters#assembly_migrating-from-iptables-to-nftables_getting-started-with-nftables which points at the fact that these utilities are deprecated in RHEL9.

This might point towards a larger effort of reviewing this role and deciding how to modernize it to work with the latest operating system.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As indicated in IDR/deployment#440 (comment), this was successfully deployed on test125 so this is functional.

There might be a future maintenance work around modernizing firewall rules but this unblocks the deployment of IDR

@dominikl
Copy link
Member

👍 Looks good to me too. I've tested the commit previously (cherry-picked from IDR/deployment#438 ) in order to spin up pilot-idr0163.

@will-moore
Copy link
Member

Is this good to merge now then? Since this is needed for progress on IDR/deployment#441 (which we could maybe try to release next week) it would be good if we can get this in.

@jburel
Copy link
Member

jburel commented Nov 19, 2024

Important: iptables-nft packages have been deprecated in Red Hat Enterprise Linux 9.
So this will need to be reviewed. This is a temporary solution

@jburel
Copy link
Member

jburel commented Nov 19, 2024

Ticket created #14

@jburel jburel merged commit 529b759 into ome:master Nov 19, 2024
3 checks passed
@pwalczysko
Copy link
Member

cosensus 0.5.0 for release

@pwalczysko
Copy link
Member

cosensus 0.5.0 for release

No, consensus changed to 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants