-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change package name #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is very minimal. Do you have a link that explains why this package was superseded by iptables-nft-services
?
The Molecule tests in this role did not fail when enabling the service but I can reproduce the error in the context of the IDR playbooks Molecule tests. Does that point at something else that the IDR playbooks causing an issue with this component?
From a quick search I came across https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/configuring_firewalls_and_packet_filters/getting-started-with-nftables_firewall-packet-filters#assembly_migrating-from-iptables-to-nftables_getting-started-with-nftables which points at the fact that these utilities are deprecated in RHEL9.
This might point towards a larger effort of reviewing this role and deciding how to modernize it to work with the latest operating system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As indicated in IDR/deployment#440 (comment), this was successfully deployed on test125
so this is functional.
There might be a future maintenance work around modernizing firewall rules but this unblocks the deployment of IDR
👍 Looks good to me too. I've tested the commit previously (cherry-picked from IDR/deployment#438 ) in order to spin up pilot-idr0163. |
Is this good to merge now then? Since this is needed for progress on IDR/deployment#441 (which we could maybe try to release next week) it would be good if we can get this in. |
|
Ticket created #14 |
cosensus 0.5.0 for release |
No, consensus changed to 0.4.1 |
This PR changed the installation package to fix the issue described on IDR/deployment#438