Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule v2 #13

Merged
merged 8 commits into from
Nov 28, 2018
Merged

Molecule v2 #13

merged 8 commits into from
Nov 28, 2018

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 16, 2018

This PR makes the necessary changes to test this role with Ansible 2.4 and Molecule 2.

  • d29afab creates the Molecule 2 initial setup using molecule init scenario -r $(basename $PWD) -s default -d docker
  • 6e398ee fixes the yamllint warnings and errors reported by molecule test
  • ae81457 and a5ab22b ccopy the v1 tests and set up the molecule configuration files. 12856f2 contains the necessary changes to upgrades the tests to be compliant with Molecule 2/testinfra 1.14 including the usage of the new host fixture.

With ome/ome-ansible-molecule#10, this PR should be tested by Travis against Ansible 2.4 in the morning https://travis-ci.org/snoopycrimecop/ansible-roles build.

Proposed tag: 3.0.2

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from the extraneous test

@manics manics merged commit 407dc0e into ome:master Nov 28, 2018
@sbesson sbesson deleted the molecule_v2 branch November 28, 2018 11:00
@sbesson
Copy link
Member Author

sbesson commented Nov 28, 2018

The role import onto Galaxy failed with

Starting import: task_id=327355, repository=openmicroscopy/ansible-role-postgresql

Task "327355" failed: 'int' object has no attribute 'get'

Unclear whether this is an issue with the role or upstream.

@sbesson
Copy link
Member Author

sbesson commented Nov 28, 2018

After fixing meta/main.yml which was causing the failed import and retagging 3.0.2, this is now deployed to https://galaxy.ansible.com/openmicroscopy/postgresql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants