-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding test that loads memo file from previous release #4237
Comments
A good starting point for this might be the logic in bioformats/components/test-suite/src/loci/tests/testng/FormatReaderTest.java Lines 2973 to 3001 in 1f03e09
This feature was been introduced in #3159 to identify whether the included changes are backwards-incompatible with memo files created by the previous release of Bio-Formats and decide whether the next release should increment the patch or minor version. Something that might need to be reviewed if we are looking into reusing the existing logic is that |
#4234 highlights that there can be cases where memo file loading breaks in a way that our current tests do not catch. Catching these issues by eye in code review is possible, but very easy to overlook.
One approach would be to store memo files generated from the previous released version in https://github.com/openmicroscopy/data_repo_config. Then we could add a test similar to https://github.com/ome/bioformats/blob/develop/components/test-suite/src/loci/tests/testng/FormatReaderTest.java#L2943 that reads the stored memo file.
The text was updated successfully, but these errors were encountered: