CV7000: handle NullPointerException when resetting allFiles in close() #4234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the reader should initialize this field as an empty ArrayList, there are scenarios where allFiles will be null when calling
close()
. A use case would be a reader initialized from a memo file created with a previous release of Bio-Formats since this field was formerly a string array set to null by default.A minimal reproducible scenario can be created by creating a TIFF file and reading using Bio-Formats 7.3.1 command-line tools with
-cache
Using a command-line tools build from the current HEAD of develop (e4ffbe8), reopening this file should fail with a NullPointerException
With this PR included, the same command should succeed.