Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null returned from getParentFile #2914

Closed
wants to merge 3 commits into from

Conversation

dgault
Copy link
Member

@dgault dgault commented Aug 1, 2017

This PR is in conjunction with ome/ome-common-java#12

To test:

  • Ensure all builds and tests are green

@sbesson sbesson modified the milestone: 5.6.0 Aug 10, 2017
@mtbc
Copy link
Member

mtbc commented Oct 1, 2017

Ready for review?

@sbesson
Copy link
Member

sbesson commented Oct 2, 2017

With ome/ome-common-java#12 requiring some work to minimize the impact on client code, would using the return value of Location.getParent() to perform the non-null check be a possibility to address this issue in the interim?

@sbesson
Copy link
Member

sbesson commented Oct 23, 2017

Closing for now. Requires a bit more investigation to address this issue while minimizing the impact on the code/readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants