Micromanager: better handling of very large *metadata.txt files #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: components/formats-bsd/src/loci/formats/in/MicromanagerReader.java Conflicts: components/formats-bsd/src/loci/formats/in/MicromanagerReader.java
|
Dataset now under |
|
Builds and tests have been unaffected by this PR. Using the suggested test files without this PR required PR is good to merge. |
|
Does this fix require ome/ome-common-java#24? In which case should we merge the PR, cut a patch release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from a private PR. Originally part of the same PR as ome/ome-common-java#24 (prior to repo split).
Original use case was larger (~7000 plane) datasets acquired using the diSPIM plugin (https://micro-manager.org/wiki/ASIdiSPIM_Plugin). I wasn't able to find a way to run a diSPIM acquisition without a connected instrument, so the closest test data is a 5000 T x 5 Z x 2 C multi-D acquisition with the relevant
SPIMmodekey added manually.Complete dataset yet to be uploaded, so not ready for final testing. Once uploaded,
showinf -nopix 1.4-large-acq-take-2_1_MMStack_Pos0_metadata.txtwithout this PR or ome/ome-common-java#24 will requireBF_MAX_MEMto be at least 1200 MB. With a build including both PRs, only 900 MB should be required. As1.4-large-acq-take-2_1_MMStack_Pos0_metadata.txtis 195 MB, a warning should be logged indicating that the file may require additional memory.Tests should continue to pass with existing Micromanager data; memo files will be affected.