Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVS: Detect label and macro if no image description #3759

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

dgault
Copy link
Member

@dgault dgault commented Jan 6, 2022

This is a rather simplistic attempt to deal with the issue detected in #3757
If no image description is present then it will try to treat the series as a label or macro.

Fixes #3757

To test:

@dgault dgault modified the milestones: 6.9.0, 6.8.1 Jan 6, 2022
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using both the newly provided SVS sample as well as former samples using for #3733. Everything works as expected with macro and label images detected appropriately.

In the absence of additional representative samples, this feels like the best compromise allowing to fix the regression for some SVS variants reported in #3757 while preserving the improvements introduced in 6.8.0

@dgault dgault merged commit f89b6a7 into ome:develop Jan 12, 2022
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/remove-label-and-macro-from-a-wsi/45630/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVS: Incorrect pyramid levels with 6.8.0
3 participants