Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellWorX/Metaxpress: Read metadata from one file per channel, to preserve all channel data #3806

Merged

Conversation

melissalinkert
Copy link
Member

Backported from a private PR.

To test, use metaxpress/samples/multi-channel-test/multi-channel.HTD. Without this PR, showinf -nopix -omexml should show 2 channels in the OME-XML, but only the first has an EmissionWavelength. With this PR, the same command should show that both channels have an EmissionWavelength set, and that the two wavelengths are different. The wavelengths can be compared against the configuration for the original pixels files (see metaxpress/samples/multi-channel-test/readme.txt).

@sbesson
Copy link
Member

sbesson commented Apr 7, 2022

A few failing tests - see https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/178146/console - which will require some configuration updates

@melissalinkert
Copy link
Member Author

Should be fixed by https://github.com/openmicroscopy/data_repo_config/pull/521/commits/f69aee2353d837b467e854215bb0f94dd7dd9900

@melissalinkert melissalinkert added this to the 6.10.0 milestone May 9, 2022
@dgault
Copy link
Member

dgault commented May 19, 2022

Builds and tests have been green with this PR and the config PR included.

Tested using the recommended sample file from metaxpress/samples/multi-channel-test.
Without the PR the sample file showed 2 channels, only the first containing EmissionWavelength:

         <Channel EmissionWavelength="488.0" EmissionWavelengthUnit="nm" ID="Channel:0:0" Name="DAPI" SamplesPerPixel="1">
            <LightSourceSettings ID="LightSource:0:0" Wavelength="488.0" WavelengthUnit="nm"/>
            <DetectorSettings Binning="1x1" ID="Detector:0:0"/>
            <LightPath/>
         </Channel>
         <Channel ID="Channel:0:1" Name="FITC" SamplesPerPixel="1">
            <LightPath/>
         </Channel>

With the PR both channels have EmissionWavelength populated and the values for each channel are different and correct:

         <Channel EmissionWavelength="488.0" EmissionWavelengthUnit="nm" ID="Channel:0:0" Name="DAPI" SamplesPerPixel="1">
            <LightSourceSettings ID="LightSource:0:0" Wavelength="488.0" WavelengthUnit="nm"/>
            <DetectorSettings Binning="1x1" ID="Detector:0:0"/>
            <LightPath/>
         </Channel>
         <Channel EmissionWavelength="568.0" EmissionWavelengthUnit="nm" ID="Channel:0:1" Name="FITC" SamplesPerPixel="1">
            <LightSourceSettings ID="LightSource:0:0" Wavelength="568.0" WavelengthUnit="nm"/>
            <DetectorSettings Binning="1x1" ID="Detector:0:0"/>
            <LightPath/>
         </Channel>

@dgault dgault merged commit 4d97456 into ome:develop May 19, 2022
melissalinkert added a commit to melissalinkert/bioformats that referenced this pull request Apr 14, 2023
This only happened when the files for the entire first field were missing.
The problem was introduced in ome#3806.
@melissalinkert melissalinkert deleted the metaxpress-htd-multi-channel-develop branch September 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants