InCell: allow mix of 2D and 3D channels to be treated as a Z stack #4270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.image.sc/t/incell-plates-with-z-stacks-cannot-be-imported-on-omero/107802 and data copied to
inbox/imagesc-107802
.As indicated in the forum post, one channel in the plate has a Z stack (16 slices), while the remaining channels have a single Z slice. The changes in lines 795 and later are to pick up the dimensions of each field as 16 Z x 4 C, with most planes blank.
The changes in lines 467-468 are necessary because the total image count is 152, and the number of planes per field is 64 - so the
expectedSeries
calculation results in 2, when there are actually 8 series (4 fields x 2 wells). This change in particular might break some older data, so we'll see what the test results are, and may need to exclude/rework this a bit.Adding to 8.1.1 milestone instead of 8.1.0, anticipating that some extra work will be needed.