-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OME-XML metadata support #47
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 92.43% // Head: 91.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 92.43% 91.62% -0.81%
==========================================
Files 3 3
Lines 185 191 +6
==========================================
+ Hits 171 175 +4
- Misses 14 16 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
👍 Converted
👎 For a converted
Additionally: only loading from the internal console works. Loading from the command line with |
2ed0306
to
2ec3548
Compare
Ah, the lack of plate loading is apparently the ome-types validation issue:
|
While trying to get the `bioformats2raw.layout` specification (ome/ngff#112) this raised its head again. Following the discussion in ome/ome-model#158 changing the size checks to `40` passes. fix: ome/bioformats#3810 fix: ome/napari-ome-zarr#47 (comment)
@@ -132,7 +133,19 @@ def f(*args: Any, **kwargs: Any) -> List[LayerData]: | |||
data = [ | |||
np.squeeze(level, axis=channel_axis) for level in node.data | |||
] | |||
metadata["name"] = [ | |||
metadata.get("name", "unnamed") for x in range(3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is range(3)
hard-coded for a 3-channel image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I assume that's what that was about, yes.
* Update Hex40 definition While trying to get the `bioformats2raw.layout` specification (ome/ngff#112) this raised its head again. Following the discussion in ome/ome-model#158 changing the size checks to `40` passes. fix: ome/bioformats#3810 fix: ome/napari-ome-zarr#47 (comment) * Bump to min_length=40
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/saving-volumetric-data-with-voxel-size-colormap-annotations/85537/24 |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/constructing-zarr-for-napari-ome-zarr/65398/4 |
NB: currently built on top of #42
Make use of metadata parsed via https://github.com/ome/ome-zarr-metadata for enriching the images in napari.
TODO: