Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Ansible 2.6 and Molecule 2 #13

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 26, 2018

As discussed earlier today, this new set of requirements supersedes the ones previously proposed in #10.

setup.py Outdated
'ansible==2.3.2',
'docker',
'ansible==2.6.3',
'docker-compose',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be docker?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this requirement from https://github.com/openmicroscopy/ome-ansible-molecule-dependencies/pull/10/files#diff-2eeaed663bd0d25b7e608891384b7298R74 it pulls docker as a dependency

Collecting docker<4.0,>=3.4.1 (from docker-compose->ome-ansible-molecule-dependencies==0.3.2.dev1)

Copy link
Member

@manics manics Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, can you make this a versioned dependency (looks like the current is 1.22.0), then this should be good to merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed. 16e4250 also contains the discussed renaming of this meta-package using the proposed ome-ansible-molecule suggestion for now although there might be better/shorted/more concise names clarifying the scope of this meta-package.

Once we have the name settled, the repo will need to be renamed before cutting a 0.4.0 release to PyPI and the new package can be consumed across all Ansible roles.

Copy link
Member

@manics manics Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll give it a final test with IDR/deployment#135 before merging. ome-ansible-molecule sounds fine to me, not overly long but not too generic.

But if others don't like that name then how about ome-ansible-deps?

manics added a commit to manics/deployment that referenced this pull request Oct 15, 2018
ome/ome-ansible-molecule#13 commit d5601fc60d2cae5fcf608cc045f6340ca7dd8c24.zip
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manics manics merged commit 4543253 into ome:master Oct 16, 2018
@sbesson sbesson deleted the ansible_2.6 branch November 2, 2018 09:06
@sbesson sbesson added this to the 0.4.0 milestone Nov 2, 2018
@sbesson
Copy link
Member Author

sbesson commented Nov 2, 2018

Now released as https://pypi.org/project/ome-ansible-molecule/0.4.0/. I will look into whether PyPI has some mechanism to annotate a project as superseded by another. Otherwise, might create a final 0.3.2 release on https://pypi.org/project/ome-ansible-molecule-dependencies/ to indicate the new meta-package should be used instead.

manics added a commit to manics/deployment that referenced this pull request Nov 30, 2018
ome/ome-ansible-molecule#13 commit d5601fc60d2cae5fcf608cc045f6340ca7dd8c24.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants