Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep release #2

Merged
merged 4 commits into from
May 10, 2020
Merged

Prep release #2

merged 4 commits into from
May 10, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented May 8, 2020

  • Add missing license file (reference in MANIFEST.in)
  • Add changelog
  • Ignore build

cc @joshmoore

@jburel
Copy link
Member Author

jburel commented May 8, 2020

Any objections to merge it now
and tag 0.1.0?

@sbesson
Copy link
Member

sbesson commented May 8, 2020

None from me, thanks for adjusting the readme. Should we have sign off from the team on Monday before releasing?

@jburel
Copy link
Member Author

jburel commented May 8, 2020

For the license file?. We can always move it and retag.
the rest has been signed off including the name that we are going to keep as it is

@sbesson
Copy link
Member

sbesson commented May 8, 2020

No, the license is fine as it is.

Re release, I was under the impression this project was still an ongoing investigation in the context ome/omero-documentation#2123 (comment). If the questions around its scope and name have been discussed and settled, then it's fine and I missed this conversation and its outcome. Has a brief summary of the decisions been published somewhere?

@jburel
Copy link
Member Author

jburel commented May 8, 2020

As indicated on the doc PR, having the "meta-package" should simplify the releases since adding for example a dependency to the meta-package should not require a doc or omero-install.
This actually simplifies the release process.
So we all agree that it was a good approach, the initial worry was the work required but since we now have everything in place and it works for the various linux flavours
we should be good to go

@jburel jburel merged commit dd9b525 into ome:master May 10, 2020
@jburel
Copy link
Member Author

jburel commented May 10, 2020

Just noticed version in file.
Quick discussion tomorrow before tagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants