Ol 5 #218
Merged
Ol 5 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply use an example map as a placeholder to show usage of OpenLayers 5 in place of the ol3-viewer
Commented out other imports that haven't been updated yet
This change means that Mask is imported after Rectangle, so the when Mask imports Rectangle, Rectangle has already been imported. Otherwise, without this change, importing Rectangle within Mask.js means that Rectangle is undefined for some reason when imported by Label.js
jburel
reviewed
Jan 20, 2019
| @@ -78,7 +78,8 @@ def run(self): | |||
| class Test(setuptools.command.install.install): | |||
|
|
|||
| def run(self): | |||
| self.spawn(['ant', 'unit-tests-only']) | |||
| # self.spawn(['ant', 'unit-tests-only']) | |||
There was a problem hiding this comment.
This and other TODOs moved to https://trello.com/c/vyZSm0fj/15-openlayers-5-build-cleanup
jburel
reviewed
Jan 20, 2019
|
Merging so we can move forward with the rest of the work |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to update to latest OpenLayers 5.3.0, which doesn't use closure compiler so it doesn't need a separate build step.
At this point (3ab6501), I'm not aware of any new bugs. All functionality should be unchanged.
I have removed the closure compiler step from the npm build commands in
package.jsonand they seem to work OK.Pre-existing bugs (might be able to fix):
Other TODOs / questions:
ant unit-tests-onlyand reactivate insetup.py/src/viewers/viewer/.globals.PROJECTIONis undefined when imported intoutils/Misc.ome.ol3in the doc strings have now been removed etc.