Fix request params #236
Merged
Fix request params #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtbc
reviewed
Feb 14, 2019
manics
reviewed
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #219
In looking to document the supported request parameters, I found that x, y and zoom weren't working.
This fixes that and documents their usage on the README.
See https://github.com/will-moore/omero-iviewer/tree/fix_request_params#supported-urls
To test: e.g. go to http://web-dev-merge.openmicroscopy.org/webclient/img_detail/160953/?dataset=27801&zm=50&x=25000&y=15000 (user-3):
?x=200&y=500centres the image at those coordinates?zm=100sets the zoom for Big images and non-tiled images. (for Big images it may pick the closest supported zoom level)Re: Also found bug in opening iviewer from webclient: ome/openmicroscopy#5953