Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu to Link to Viewport #240

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Feb 20, 2019

This adds the "get link to current viewport" that we have in the old webgateway viewer, including the newly-fixed x, y, and zoom parameters to link to the current location AND rendering settings.
Card: https://trello.com/c/PuziBOFJ/5-image-link-feature

To test:

  • Pan, zoom and update rendering setting on an image without saving (include quantization family etc)
  • Right-click on image -> Get Link to Viewport
  • Copy URL and check that by pasting it in a new window, all settings are preserved:
    • Channel colours, on/off, ranges, quantization family, coefficient, inverted etc.
    • Zoom and X and Y coordinates of the viewport are respected
  • Also, if the original URL had e.g. dataset=1, check that this is included in the new URL (image in multiple Datasets should preserve which Dataset is shown in thumbnail panel).

@will-moore will-moore marked this pull request as ready for review February 27, 2019 13:28
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jburel jburel added this to the 0.7.0 milestone Mar 19, 2019
@jburel jburel merged commit d4acbdb into ome:master Mar 27, 2019
@will-moore will-moore mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants