-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roi tiles #242
Roi tiles #242
Conversation
If we requestRois here (when switching images and the ROI tab is active) then we load ROIs before we know the current Z/T index of the image and before any cached Z/T settings have been applied. We don't need to request ROIs here, since the image_info will do this on success from loading image info if ROIs tab is active
This should keep the regions data in sync with image_info Z and T index since we keep making requestData calls until no more requestData calls happend while is_pending.
Showed @jburel the ROI shape counts when zooming out: Discussion:
|
Current status: for single-plane images with > 500 ROIs, we don't load ROIs in ROI table but instead load them via Tiles (TiledRegions layer) on the image. When a shape is clicked on the image, it is transferred to the Vector Regions layer for editing, and also it shows up in the ROI table. You can then edit and Save the shape, and draw new shapes: |
This is needed in the regions-list.html table
This uses Tile-based ROIs on single-plane images with > 500 ROIs.
On multi-plane images, if there are more than 500 ROIs on any plane, simple pagination is used.
Instead of the previous strategy #227 of replacing the existing Vector Regions layer with Tiled Regions layer, this tries to use both alongside each other. This means that we can still use the existing Regions layer for editing ROIs we have loaded in the ROI table (as in #231) but we can browse Tiled ROIs on the image.
If you click a Tile-based ROI on the image, it loads the ROI into the Table (and the Vector Regions layer) so you can edit them.
If we wanted to pursue this strategy, other TODOs:
all_roi_ids