Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 11 thumbnails in Dataset #246

Merged
merged 1 commit into from
Mar 14, 2019
Merged

fix 11 thumbnails in Dataset #246

merged 1 commit into from
Mar 14, 2019

Conversation

will-moore
Copy link
Member

To test:

  • Find or create a Dataset with 11 images (or 21, or 31 etc)
  • Open first image in iviewer
  • Scroll thumbnail slider - check that thumbs load correctly and the LAST thumbnail loads.

@will-moore will-moore changed the title Fix off-by-1 error loading thumbs from Dataset of 11 fix 11 thumbnails in Dataset Mar 6, 2019
@joshmoore
Copy link
Member

Thanks, @will-moore. Do you have any idea how long this has been around? What tests would prevent this type of thing from sneaking through?

@will-moore
Copy link
Member Author

@joshmoore I believe it's been there since this functionality was added in #207. There was quite extensive testing as part of that PR but not testing with Dataset of all different numbers of images.

@jburel jburel added this to the 0.7.0 milestone Mar 14, 2019
@jburel jburel merged commit a833999 into ome:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtbc mtbc mtbc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@will-moore @joshmoore @mtbc @jburel