Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conn.SERVICE_OPTS in well_images() #271

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

will-moore
Copy link
Member

See #270

To test:

  • Browse to a Well in your non-default group
  • Open-with iviewer. URL is e.g. iviewer/?well=101
  • Should see images in the well etc instead of "No image data"
  • Also can confirm directly that /iviewer/well_images/?id=101 shows the correct response.

@mtbc
Copy link
Member

mtbc commented Aug 1, 2019

This isn't working for me at all in Firefox or Chromium, I just get a blank tab (with a correct title) and TypeError stuff in the JavaScript console.

@will-moore
Copy link
Member Author

Something else is broken - need to investigate when I'm back.
But I think this PR is working: e.g. user-3 for well https://merge-ci.openmicroscopy.org/web/webclient/?show=well-11014 - this works: https://merge-ci.openmicroscopy.org/web/iviewer/well_images/?id=11014

@will-moore
Copy link
Member Author

The error should be fixed with 7e894df in #264.

@jburel jburel merged commit 5bc0c3f into ome:master Aug 8, 2019
@jburel jburel added this to the 0.8.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants