Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-viewer save rois #279

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix multi-viewer save rois #279

merged 1 commit into from
Sep 17, 2019

Conversation

will-moore
Copy link
Member

To test:

  • Open the same image in 2 viewers at the same time
  • Draw some ROIs in one, don't save.
  • Select the other viewer.
  • Dialog says "Save?" -> Yes
  • Other viewer should load the newly saved ROIs
  • Also, in multi-viewer mode, editing and saving ROIs should work normally (ROIs updated from unsaved to saved state in the table)

@will-moore will-moore changed the title Fix saving of ROIs in multi-viewer mode Fix multi-viewer save rois Sep 9, 2019
@pwalczysko
Copy link
Member

merge-ci server is not usable now because of https://openmicroscopy.slack.com/archives/C0K5EED3R/p1568108686329900 - will wait with testing here until this is resolved.

@pwalczysko
Copy link
Member

Actually, the iviewer works fine on merge-ci. The functionality here is as expected.

Ready to merge FMPOV

@jburel jburel merged commit 0117264 into ome:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-moore @pwalczysko @jburel