Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore missing projection-bytes config #377

Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Apr 6, 2021

Fixes #375.

Handle missing server config max_projection_bytes
Not found on OMERO.server before 5.6.1

To test:

  • deploy with OMERO.server 5.6.0

Not found on OMERO.server before 5.6.1
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a pilot IDR server (with a 5.6.0 server). While OMERO.iviewer was previously failing with the last release, it now opens as expected.

Also tested on a couple of datasets with various Z sizes that the projection are enabled/disabled with the same criteria as current production IDR.

Using the developer tools, I can confirm that MAX_PROJECTION_BYTES is set to "None" which I assume is the expected behavior

            window.INITIAL_REQUEST_PARAMS['WEBGATEWAY'] = "/webgateway/";
            window.INITIAL_REQUEST_PARAMS['WEBCLIENT'] = "/webclient/";
            window.INITIAL_REQUEST_PARAMS['WEB_API_BASE'] = "/api/v0/";
            window.INITIAL_REQUEST_PARAMS['ROI_PAGE_SIZE'] = "500";
            window.INITIAL_REQUEST_PARAMS['MAX_PROJECTION_BYTES'] = "None";

The above made me wonder: where is the threshold logic now happening since MAX_PROJECTION_BYTES is set to -1 and there is no server configuration specifying the maximum pixel size for projections?

@will-moore
Copy link
Member Author

I think that if there is no max_projection_bytes set anywhere, then iviewer will enable projection for non-tiled images below a plane size of 2048 x 2048 (see #349).

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. At least from the IDR use case standpoint, this is good to merge and I could conceive an immediate iviewer release that we could consume in prod96 (I can handle the release if everyone is happy with the suggestion) /cc @jburel @joshmoore

@sbesson
Copy link
Member

sbesson commented May 31, 2021

Discussed today. Merging to move towards a 0.11.0 release of OMERO.iviewer that we can deploy on a pilot IDR for testing.

@sbesson sbesson merged commit a221e1a into ome:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with OMERO.server 5.6.0
2 participants