Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel min spinner fix #460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

will-moore
Copy link
Member

Fixes issues for 'start' channel slider input as reported at ome/ZarrReader#67 (comment).

  • With a very large negative number, the formatting of the number as required for floats was resulting in Nan.
  • Also, the spinner behaviour (jQuery plugin) doesn't work with very large negative numbers. Reducing the minimum number fixes this issue.

Without this limit, entering values into the field can get modified or rounded massively
@jburel
Copy link
Member

jburel commented Nov 21, 2023

is the change deployed on idr-testing?

@jburel
Copy link
Member

jburel commented May 13, 2024

Does this PR need to be considered for the upcoming release?

@will-moore
Copy link
Member Author

I tried to find images where this bug was still showing, so as to demonstrate the fix, but e.g. with the image reported originally I don't see this issue any more: https://idr-testing.openmicroscopy.org/webclient/img_detail/10648053/

It's possible that some other dependency update addressed the issue? 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants