Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rois tab ui reshuffle and styling #57

Merged
merged 16 commits into from
May 8, 2017

Conversation

waxenegger
Copy link
Member

@waxenegger waxenegger commented May 2, 2017

see: ome/design#75

  • roi/shapes table: rearranged columns, border transparent instead of black
  • delete is now a button (not dropdown) and next to edit dropdown acting like other edit widgets on selection
  • show roi toggle was already visually removed in Info tab #55 but now internal flag was removed and along with it a refactoring was done
  • all entries in the rois table will be hidden by a checkbox on the header
  • spacing for drawing menu icons was altered to give more space between select and rest of icons
  • although not rois tab related the remaining code for the scalbar toggle got removed (after: scalebar - increase spectrum (finer unit differentiation) #54)
  • 3 fixes: delete of multiple shapes, modify circle ignoring attachment, no canvas redraw on panel collapse
  • rois backend request made on demand (first click on tab)
  • change of default selection style and fill color

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build iviewer-merge#252. See the console output for more details.
Possible conflicts:

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build iviewer-merge#266. See the console output for more details.
Possible conflicts:

@waxenegger
Copy link
Member Author

@jburel and @will-moore:

I'm going to list this PR for review despite the inline comment edit not being in there. That's something I wanted to discuss again since it would behave differently (acts on multiple selection actions at the moment), would have different (font) size/length in terms of input field for the row and last but not least only work if I disallowed selection of a row along the comment column.

But there is already enough in this PR to justify a review and there is another one waiting for the channel settings (#58) for which I'm going to have to touch css again.

@will-moore
Copy link
Member

  • ROI table looks good
  • Delete working as expected
  • Show/hide toggles are behaving fine, Show/hide ALL is good too.
  • Layout of drawing icons looks nice.
  • ROIs are only loaded when the ROIs tab is selected
  • Default stroke/fill colours are yellow/transparent as expected.

Functionality is all good ;).
Ready to merge for me.

@jburel
Copy link
Member

jburel commented May 5, 2017

If I click Edit>Select All, the UI is removed from the ROIs tab.

@waxenegger
Copy link
Member Author

@jburel the last commit should fix that. seems we noticed that about the same time.

@jburel
Copy link
Member

jburel commented May 8, 2017

The problem is now fixed. Merging

@jburel jburel merged commit 26f7caf into ome:master May 8, 2017
@waxenegger waxenegger deleted the rois_tab_ui_reshuffle branch May 15, 2017 01:23
@jburel jburel modified the milestone: 0.1.0 May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants